Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(radio): Fieldset element unnecessary styles removal. #347

Merged
merged 5 commits into from
Nov 2, 2021

Conversation

creador-dev
Copy link
Member

Radio fieldset element unnecessary space and border have been removed. I have used important so this CSS can't be overridden by WordPress default CSS.

@creador-dev creador-dev marked this pull request as draft October 7, 2021 13:59
@creador-dev creador-dev marked this pull request as ready for review October 7, 2021 14:00
@creador-dev creador-dev closed this Oct 7, 2021
@creador-dev creador-dev reopened this Oct 7, 2021
@iamleigh iamleigh changed the title Radio fieldset element unnecessary space and border removal - SUI 59 🐛 fix(radio): Fieldset element unnecessary styles removal. Oct 7, 2021
@iamleigh iamleigh self-requested a review October 7, 2021 14:14
@iamleigh iamleigh added the bug Something isn't working label Oct 7, 2021
@iamleigh iamleigh marked this pull request as draft October 7, 2021 14:32
@creador-dev creador-dev marked this pull request as ready for review October 7, 2021 14:46
Copy link
Member Author

@creador-dev creador-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sure

@creador-dev creador-dev requested a review from iamleigh October 7, 2021 14:47
Copy link
Member Author

@creador-dev creador-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the necessary changes.

Copy link
Contributor

@iamleigh iamleigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@creador-dev please, remove yarn.lock file from the PR. Also, take a look at my other comment.

@creador-dev creador-dev requested a review from iamleigh October 22, 2021 18:25
@iamleigh iamleigh merged commit 23d2ba5 into wpmudev:development Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants