[wpimath] change G to gearing in LinearSystemId factories #5834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
reviewed
Oct 27, 2023
wpimath/src/main/java/edu/wpi/first/math/system/plant/LinearSystemId.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/math/system/plant/LinearSystemId.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/math/system/plant/LinearSystemId.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/math/system/plant/LinearSystemId.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/math/system/plant/LinearSystemId.java
Outdated
Show resolved
Hide resolved
I saw a suggestion from rzblue in the discord about this and already changed it. |
|
/format |
|
You'll need to update the header as well |
|
/format |
DeltaDizzy
changed the title
|
Java still capitalizes "gearing" in the exception message. |
auscompgeek
approved these changes
Nov 7, 2023
rzblue
approved these changes
Nov 9, 2023
Starlight220
pushed a commit
to Starlight220/allwpilib
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gearing parameter being called "G" was often confusing when using LinearSystemId, and making the name more descriptive would help avoid that.