Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move command over to new v2 structure #21

Merged
merged 29 commits into from
Aug 21, 2018
Merged

Conversation

wojsmol
Copy link
Contributor

@wojsmol wojsmol commented Aug 12, 2018

fixes #20
test results from my fork https://travis-ci.com/wojsmol/wp-super-cache-cli.

@wojsmol
Copy link
Contributor Author

wojsmol commented Aug 12, 2018

fixes #20

@szepeviktor
Copy link

szepeviktor commented Aug 12, 2018

fixes #20

It needs to be added in the top comment to actually close #20.

@wojsmol
Copy link
Contributor Author

wojsmol commented Aug 12, 2018

@szepeviktor Ives if github don't catch this then this will be reference for @schlessera 😄

composer.json Outdated
@@ -15,9 +15,33 @@
"role": "Developer"
}],
"require": {
"php": ">=5.3.0"
"php": ">=5.4",
"wp-cli/extension-command": "2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a testing requirement, it should be moved into "require-dev" section.

@schlessera
Copy link
Member

Ah, clicked on the request review button too fast...

@wojsmol Please make the following additional changes:

  • move cli.php into src/WPSuperCache_Command.php
  • add PSR-4 autoloader that maps src/ to an empty namespace
  • add a wp-cli.yml file that requires the wp-super-cache-cli.php file

@wojsmol
Copy link
Contributor Author

wojsmol commented Aug 14, 2018

I'm temporally using in tests this link /~https://github.com/wojsmol/wp-super-cache-cli/archive/tov2.zip

@wojsmol
Copy link
Contributor Author

wojsmol commented Aug 15, 2018

Thank you @swissspidy 😄

@schlessera schlessera merged commit ecc9108 into wp-cli:master Aug 21, 2018
@schlessera schlessera changed the title convert to v2 Move command over to new v2 structure Aug 21, 2018
@wojsmol wojsmol deleted the tov2 branch August 21, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move command over to new v2 structure
4 participants