[BE] JWT 토큰을 통해 자신의 스케줄을 조회할 수 있는 기능 추가 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokmyungham
requested review from
ehBeak,
ikjo39,
hw0603 and
seunghye218
as code owners
Test Results47 tests 47 ✅ 4s ⏱️ Results for commit 82b24c8. ♻️ This comment has been updated with latest results. |
ehBeak
approved these changes
Jul 26, 2024
Comment on lines
+144
to
+153
| private void createAttendeeSchedule(Attendee attendee) { | ||
| List<Schedule> schedules = new ArrayList<>(); | ||
| schedules.add(new Schedule(attendee, today, Timeslot.TIME_0300)); | ||
| schedules.add(new Schedule(attendee, today, Timeslot.TIME_0400)); | ||
| schedules.add(new Schedule(attendee, today, Timeslot.TIME_0500)); | ||
| schedules.add(new Schedule(attendee, tomorrow, Timeslot.TIME_1600)); | ||
| schedules.add(new Schedule(attendee, tomorrow, Timeslot.TIME_1700)); | ||
| schedules.add(new Schedule(attendee, tomorrow, Timeslot.TIME_1300)); | ||
| scheduleRepository.saveAll(schedules); | ||
| } |
seunghye218
approved these changes
Jul 26, 2024
hw0603
reviewed
Jul 26, 2024
Comment on lines
+94
to
+99
| Meeting meeting = meetingRepository.findByUuid(uuid) | ||
| .orElseThrow(() -> new MomoException(MeetingErrorCode.NOT_FOUND_MEETING)); | ||
|
|
||
| Attendee attendee = attendeeRepository.findByIdAndMeeting(attendeeId, meeting) | ||
| .orElseThrow(() -> new MomoException(AttendeeErrorCode.NOT_FOUND_ATTENDEE)); | ||
|
|
There was a problem hiding this comment.
나중에 Attendee와 Meeting이 일치하는지 여부는 도메인의 책임으로 넘기면 좋을 것 같아요!
There was a problem hiding this comment.
추후 코드를 깔끔하게 갈고 닦아봅시다 ✈
hw0603
approved these changes
Jul 26, 2024
seokmyungham
force-pushed
the
feat/97-find-my-schedule
branch
from
7c1da61 to
82b24c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
특이 사항
리뷰 요구사항 (선택)