[BE] 약속 생성 API에서 바디를 통해 uuid를 제공 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: seunghye218 <seunghye@student.42seoul.kr>
ehBeak
requested review from
ikjo39,
hw0603,
seokmyungham and
seunghye218
as code owners
Test Results43 tests 43 ✅ 4s ⏱️ Results for commit 1e6bff0. ♻️ This comment has been updated with latest results. |
ikjo39
approved these changes
Jul 25, 2024
seunghye218
approved these changes
Jul 25, 2024
hw0603
approved these changes
Jul 25, 2024
| public ResponseEntity<MomoApiResponse<MeetingSharingResponse>> create( | ||
| @RequestBody @Valid MeetingCreateRequest request | ||
| ) { | ||
| MeetingSharingResponse response = meetingService.create(request); |
There was a problem hiding this comment.
현재 임시 구현일수도 있지만, 지금과 같은 맥락에서 body에 UUID를 담아 응답하는 구현이 계속 유지된다면 나중에 MeetingSharingResponse라는 레코드명은 수정이 필요할 것 같아요!
There was a problem hiding this comment.
그렇네요! 이후 분리하도록 하겠습니다~
seokmyungham
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
약속을 생성할 때, 약속의 uuid를 응답 바디에 넣어 보냅니다.
특이 사항
리뷰 요구사항 (선택)