Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] CORS Config 추가 #18

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[BE] CORS Config 추가 #18

merged 1 commit into from
Jul 16, 2024

Conversation

ikjo39
Copy link
Contributor

@ikjo39 ikjo39 commented Jul 16, 2024

관련 이슈

  • resolves: #11

작업 내용

  • CORS 설정 파일 추가
  • 서버 내 모든 API에 대해 CORS 허용
  • 모든 출처에 대한 CORS 허용
  • 모든 HTTP 메서드에 대한 CORS 허용

특이 사항

웹 서버 배포 후 특정 출처를 명시해야할 필요성이 있어요:)
쿠키/세션과 같은 인증 정보로 다룬다면 관련 설정을 추가해주어야 합니다.
현재 POST, GET에 대해 무리없이 동작할 것으로 예상해요

리뷰 요구사항 (선택)

@ikjo39 ikjo39 added 🐈‍⬛ 백엔드 백엔드 관련 이슈에요 :) 🚀 기능 기능을 개발해요 :) labels Jul 16, 2024
@ikjo39 ikjo39 added this to the 2차 데모데이 milestone Jul 16, 2024
@ikjo39 ikjo39 self-assigned this Jul 16, 2024
@ikjo39 ikjo39 changed the title feat(CorsConfig): CORS Config 추가 [BE] CORS Config 추가 Jul 16, 2024
Copy link
Contributor

@seokmyungham seokmyungham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +12 to +13
registry.addMapping("/**")
.allowedOrigins("*");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체 허용하는 부분 나중에 잊지 않고 다시 설정해주기만 하면 좋을 것 같아요👍

@ikjo39 ikjo39 merged commit f1f9c68 into develop Jul 16, 2024
hw0603 referenced this pull request in hw0603/momo-cicd-playground Jul 19, 2024
@ikjo39 ikjo39 deleted the feat/11-set-cors-config branch July 21, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐈‍⬛ 백엔드 백엔드 관련 이슈에요 :) 🚀 기능 기능을 개발해요 :)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants