-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add priority menu to tabs #4641
Conversation
I agree this is a better one, thanks for putting the effort in. Can we use horizontal dots instead of vertical ones? This should also be the common default for other sites. |
Sure I can but without a border around the button and beside text this variant looks better IMO. And a lot of mobile apps use vertical docs e.g. GitHub, Firefox, Mastodon |
@pat-s you would still prefer horizontal dots? |
I can also live with vertical ones if you have a strong preference for it. Yet this is what I see on iPhone 15 (safari) with default settings: This is caused if the language is "german" as the "pipeline ausführen" button is then too large and collapses everything on the left. The dots then expand to the left and leave the screen. Would it be complicated to enforce showing at least one item at all times? This would then avoid the menu issue going out of bounds and improve the overall feel. |
Good catch, will fix that case. |
@anbraten as your javascript knowledge is way better than mine your feedback would be very welcome. |
No we can proceed IMO. Can be improved later as well if there is any feedback. |
@xoxys Leaving the conflicts to you. |
00f8144
to
fa3ce5e
Compare
fa3ce5e
to
8790d37
Compare
8790d37
to
0be286a
Compare
Fixed it: Bildschirmaufzeichnung.vom.2025-01-08.22-50-54.mp4 |
Thanks! The only last nit I would have is that the menu doesn't vanish if one clicks on an element outside the menu that is within the overall tab list (e.g. 'tasks' or 'errors'). |
Lets fix it before merge. Should be easy enough :) |
4b6b91e
to
06dee0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels great now!
(and just a "little bit" of work in the end 😆️)
Tearing down https://woodpecker-ci-woodpecker-pr-4641.surge.sh |
Supersedes: #4610
Fixes: #2162 (comment)
Adds a priority plus menu to tabs that contains all tabs items that don't fix into the available screen size. The wordwrap issue seen in one of the demo videos was fixed already.
Bildschirmaufzeichnung.vom.2024-12-29.15-07-34.mp4
Bildschirmaufzeichnung.vom.2024-12-29.15-07-57.mp4