Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority menu to tabs #4641

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Add priority menu to tabs #4641

merged 5 commits into from
Jan 10, 2025

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Dec 29, 2024

Supersedes: #4610
Fixes: #2162 (comment)

Adds a priority plus menu to tabs that contains all tabs items that don't fix into the available screen size. The wordwrap issue seen in one of the demo videos was fixed already.

Bildschirmaufzeichnung.vom.2024-12-29.15-07-34.mp4
Bildschirmaufzeichnung.vom.2024-12-29.15-07-57.mp4

@xoxys xoxys added ui frontend related refactor delete or replace old code labels Dec 29, 2024
@pat-s
Copy link
Contributor

pat-s commented Dec 29, 2024

I agree this is a better one, thanks for putting the effort in.

Can we use horizontal dots instead of vertical ones? This should also be the common default for other sites.

@xoxys
Copy link
Member Author

xoxys commented Dec 29, 2024

Sure I can but without a border around the button and beside text this variant looks better IMO. And a lot of mobile apps use vertical docs e.g. GitHub, Firefox, Mastodon

@xoxys
Copy link
Member Author

xoxys commented Dec 29, 2024

@pat-s you would still prefer horizontal dots?

@pat-s
Copy link
Contributor

pat-s commented Dec 29, 2024

I can also live with vertical ones if you have a strong preference for it.

Yet this is what I see on iPhone 15 (safari) with default settings:

image

This is caused if the language is "german" as the "pipeline ausführen" button is then too large and collapses everything on the left. The dots then expand to the left and leave the screen.

Would it be complicated to enforce showing at least one item at all times? This would then avoid the menu issue going out of bounds and improve the overall feel.

@xoxys
Copy link
Member Author

xoxys commented Dec 29, 2024

Good catch, will fix that case.

@xoxys xoxys requested a review from a team December 29, 2024 22:29
@xoxys
Copy link
Member Author

xoxys commented Dec 29, 2024

@anbraten as your javascript knowledge is way better than mine your feedback would be very welcome.

@pat-s
Copy link
Contributor

pat-s commented Dec 30, 2024

@xoxys Do you want to wait here until @anbraten replied?

@xoxys
Copy link
Member Author

xoxys commented Dec 30, 2024

No we can proceed IMO. Can be improved later as well if there is any feedback.

@pat-s
Copy link
Contributor

pat-s commented Jan 4, 2025

@xoxys Leaving the conflicts to you.

@pat-s pat-s marked this pull request as draft January 5, 2025 21:13
@xoxys xoxys force-pushed the tab-priority-menu branch from 00f8144 to fa3ce5e Compare January 8, 2025 20:18
@xoxys xoxys marked this pull request as ready for review January 8, 2025 20:19
@xoxys xoxys force-pushed the tab-priority-menu branch from fa3ce5e to 8790d37 Compare January 8, 2025 20:19
@xoxys xoxys requested review from a team and removed request for a team January 8, 2025 20:19
@pat-s
Copy link
Contributor

pat-s commented Jan 8, 2025

The duration infos should be place above the row containing the menu? I am not sure if you wanted to do this on purpose to save space or if this is an undesired change?

image

@xoxys xoxys force-pushed the tab-priority-menu branch from 8790d37 to 0be286a Compare January 8, 2025 21:54
@xoxys
Copy link
Member Author

xoxys commented Jan 8, 2025

Fixed it:

Bildschirmaufzeichnung.vom.2025-01-08.22-50-54.mp4

@xoxys
Copy link
Member Author

xoxys commented Jan 8, 2025

I also adjusted the drop down:

image

The counter badge was removed intentionally due to the limited space.

@pat-s
Copy link
Contributor

pat-s commented Jan 8, 2025

Thanks! The only last nit I would have is that the menu doesn't vanish if one clicks on an element outside the menu that is within the overall tab list (e.g. 'tasks' or 'errors').
Seems like a niche/edge case, I am also fine with the current state!

@xoxys
Copy link
Member Author

xoxys commented Jan 8, 2025

Lets fix it before merge. Should be easy enough :)

@xoxys xoxys force-pushed the tab-priority-menu branch from 4b6b91e to 06dee0c Compare January 9, 2025 14:55
@xoxys xoxys requested a review from pat-s January 9, 2025 14:55
Copy link
Contributor

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels great now!

(and just a "little bit" of work in the end 😆️)

@xoxys xoxys merged commit 025ecdd into main Jan 10, 2025
7 checks passed
@xoxys xoxys deleted the tab-priority-menu branch January 10, 2025 06:38
@woodpecker-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants