-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix steamcmd to properly use STEAMBETAFLAG #93
Conversation
Thanks for opening the PR. Have you tested this? I remember this was done intentionally as it wouldn't work otherwise. Though that was 8 months ago, and this repo has gone through a lot of changes in that time, so there's certainly a chance that it's no longer functioning as expected :) If it does work, does it also work when the flag is not provided? |
Yes, I tested it locally, it worked for me. I cloned the repository in my docker-compose folder and changed the file as in the PR. Then I issued Here's my docker-compose.yml
|
I'm gonna check if this also works with STEAMBETA=false. |
Unfortunately the container seems to crash when STEAMBETA=false. I suspect that's because of the empty set of quotation marks? It starts fine when I remove the quotation marks around |
Yeah, I assumed as much. One way to do it is to load the variable into an array along with the previous command args, then pass the array to Does it work without the quotation marks for both |
Alright, I just booted back into linux to test this properly! :) I changed the line in run.sh to
And tested it with
and with
In both cases I deleted the
|
5dee589
to
f14f8bc
Compare
Ayy, good stuff! Just to verify, did you confirm that the flag being |
Yes, (I did not try to connect to the server, that's what I got from the logs.) |
Sweet, thanks for your hard work! It's really appreciated :) |
tested this fix, and it works :-) Thanks 👍 |
It seems the STEAMBETAFLAG is not properly passed to steamcmd. This fixes issues with server being out of date when using the experimental branch.