Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment for docker-compose #52

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Conversation

CoMPaTech
Copy link
Contributor

Great work ... ran your container happily for a few hours yesterday ... from the looks of the server-logs it's still running (left it running without players). Hopefully this small addition is useful for someone!

@wolveix
Copy link
Owner

wolveix commented Oct 28, 2021

Hey! Thanks for taking the time to submit this pull request :)

While I agree with adding the environment variable into the Docker examples (even if it's set to false by default), I don't believe the .env contribution really adds anything unfortunately. You can set the value very easily without it, and I feel like it adds another layer of complexity for less experienced users.

I'd certainly appreciate your feedback if you feel differently though!

@CoMPaTech
Copy link
Contributor Author

Well, you could also suggest someone adding it to the compose-file with true for that matter, this is better way of working but you will need to expose it obviously. Otherwise feel free to close it :)

        environment:
             - STEAMBETA=true

@wolveix
Copy link
Owner

wolveix commented Oct 28, 2021

It's a better way of working for people that understand how to use it. A lot of people that use this image aren't too familiar with Docker or Linux, so I don't see the benefit in adding something that complicates a process that is already incredibly simple :)

Thank you for your contribution, though!

Copy link
Contributor Author

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wolveix wolveix merged commit 835f738 into wolveix:main Oct 28, 2021
@CoMPaTech CoMPaTech deleted the env_set branch October 28, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants