Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update Netlify SSR link #8700

Merged
merged 3 commits into from
Oct 5, 2023
Merged

fix: Update Netlify SSR link #8700

merged 3 commits into from
Oct 5, 2023

Conversation

jacobdalamb
Copy link
Contributor

@jacobdalamb jacobdalamb commented Sep 28, 2023 •
edited by alexanderniebuhr
Loading

Changes

Testing

N/A

Docs

/cc @withastro/maintainers-docs for feedback!

@jacobdalamb jacobdalamb requested a review from a team as a code owner September 28, 2023 20:55
@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 8d2db2e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 28, 2023
alexanderniebuhr
alexanderniebuhr reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@alexanderniebuhr alexanderniebuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know why you changed the link, however using the new link I do not get moved to the heading, while the old link still moves me to the Adapter for SSR/Edge. Maybe worth double checking?

@jacobdalamb
Copy link
Contributor Author

I know why you changed the link, however using the new link I do not get moved to the heading, while the old link still moves me to the Adapter for SSR/Edge. Maybe worth double checking?

Well that's because the another PR hasn't been merged.

@ematipico
Copy link
Member

ematipico commented Oct 4, 2023 •
edited
Loading

@jacobthesheep could you address the comment in the other PR, please? It seems there are broken links. As you said, we can't merge this PR if the other isn't merged.

sarah11918
sarah11918 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming! This change is what the docs PR needs. It'll all work out, and the docs one will be merged and live before this one carries over. Docs has control over when this PR merges into docs, so we can merge in the proper order over there. No harm in merging here.

@ematipico ematipico merged commit 78adbc4 into withastro:main Oct 5, 2023
@astrobot-houston astrobot-houston mentioned this pull request Oct 5, 2023
Merged
@jacobdalamb jacobdalamb deleted the fix/netlify-ssr-link branch October 5, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderniebuhr alexanderniebuhr alexanderniebuhr left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacobdalamb @ematipico @sarah11918 @alexanderniebuhr