-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Content] Throw on relative image usage #5648
Conversation
🦋 Changeset detectedLatest commit: c2f2435 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Can this check be optional? Right now relative paths are the only way to reference images from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think unfortunately, this is why this setting can't be optional. We're trying to protect against anyone from relying on the current unspecified behavior. The eventual plan is to specify the correct behavior for relative paths, which likely means that they'll be resolved and treated as actual assets. That would also solve the |
ae93337
to
c2f2435
Compare
Changes
We decided relative image resolution was out-of-scope for the Content Collections RFC. Throw on relative image paths in
src/content/
for Markdown and MDX.Testing
Manual testing
Docs
N/A - Already documented that Markdown and MDX are the only allowable files.