-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support session typing #13320
Conversation
🦋 Changeset detectedLatest commit: 39a3048 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #13320 will not alter performanceComparing Summary
|
This is to be merged after the 5.4 release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking to avoid merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be possible to add types tests under test/types
?
@florian-lefebvre done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have unused imports in the test, but apart from that looks good!
Changes
Adds support for typing experimental session data. This works similarly to typing of Astro.locals, using
src/env.d.ts
to define ambient types that extendApp.SessionData
. For example:Any keys not defined in this interface will be treated as
any
.Then when you access
Astro.session
in your components, any defined keys will be typed correctly:Testing
Tested manually

Docs
Docs PR: withastro/docs#11068
RFC update to follow