Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes property shadowing for form.attributes #13313

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fixes property shadowing for form.attributes #13313

merged 1 commit into from
Feb 26, 2025

Conversation

martrapp
Copy link
Member

Changes

When a form contains an input field named attributes, this shadows the access to the form.attributes property.
Changed property access to get the real thing.

Closes #13307

Testing

extended exiting form-one.astro

Docs

n.a., bugfix

Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: 9f2f959

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 25, 2025
Copy link

codspeed-hq bot commented Feb 25, 2025

CodSpeed Performance Report

Merging #13313 will not alter performance

Comparing mt/attributes (9f2f959) with main (2e1321e)

Summary

✅ 6 untouched benchmarks

@ematipico ematipico merged commit 9e7c71d into main Feb 26, 2025
16 checks passed
@ematipico ematipico deleted the mt/attributes branch February 26, 2025 10:55
@astrobot-houston astrobot-houston mentioned this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Form submission crashes when input has name="attributes" with View Transitions enabled (ClientRouter)
2 participants