Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Manager::contact_by_id #91

Merged
merged 4 commits into from
Feb 6, 2023
Merged

Fix Manager::contact_by_id #91

merged 4 commits into from
Feb 6, 2023

Conversation

nanu-c
Copy link
Contributor

@nanu-c nanu-c commented Jan 10, 2023

This wasn't working.

@nanu-c nanu-c force-pushed the fix_get_contact_by_id branch from 6b29208 to 42fe697 Compare January 10, 2023 09:56
@gferon gferon changed the title fix get contact by id Fix get contact by id Feb 6, 2023
@gferon gferon force-pushed the fix_get_contact_by_id branch from 292cfd4 to 5c15e9a Compare February 6, 2023 10:17
@gferon
Copy link
Collaborator

gferon commented Feb 6, 2023

@nanu-c the real issue was the double serialization (which was a leftover from the Store refactoring I did a while ago). I also added a get-contact command to the example CLI to make sure it works as intended.

@gferon gferon changed the title Fix get contact by id Fix Manager::contact_by_id Feb 6, 2023
@gferon gferon merged commit 1ec0128 into whisperfish:main Feb 6, 2023
@gferon gferon added this to the 0.5.0 milestone Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nanu-c @gferon