This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
Fix all occurrences of missing the client object for get() calls #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also noticed the 'token' variable was being used without it being declared in some classes in the resources folder. Removed those occurrences as well. |
|
Added a test which reproduces the original issue on the master branch. Followed the pattern of the other tests. Utilizing the 'next' field in the first request triggers the original problem. |
westonplatter
approved these changes
Sep 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all occurrences of get(...) with client.get(...) in the resources folder.
Addresses #43