Fix gradient syntax #80
Conversation
| background-image: linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: -webkit-linear-gradient(to bottom, #0088cc, #0044cc); | ||
| background-image: -o-linear-gradient(to bottom, #0088cc, #0044cc); | ||
| background-image: linear-gradient(to bottom, #0088cc, #0044cc); |
There was a problem hiding this comment.
Color literals like #0088cc should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #0044cc should only be used in variable declarations; they should be referred to via variable everywhere else.
| background-image: -o-linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: -webkit-linear-gradient(to bottom, #0088cc, #0044cc); | ||
| background-image: -o-linear-gradient(to bottom, #0088cc, #0044cc); |
There was a problem hiding this comment.
Avoid vendor prefixes.
Color literals like #0088cc should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #0044cc should only be used in variable declarations; they should be referred to via variable everywhere else.
| background-image: -webkit-linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: -o-linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: -webkit-linear-gradient(to bottom, #0088cc, #0044cc); |
There was a problem hiding this comment.
Avoid vendor prefixes.
Color literals like #0088cc should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #0044cc should only be used in variable declarations; they should be referred to via variable everywhere else.
| background-image: -moz-linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: -ms-linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: -moz-linear-gradient(to bottom, #0088cc, #0044cc); | ||
| background-image: -ms-linear-gradient(to bottom, #0088cc, #0044cc); |
There was a problem hiding this comment.
Avoid vendor prefixes.
Color literals like #0088cc should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #0044cc should only be used in variable declarations; they should be referred to via variable everywhere else.
| @@ -546,12 +546,12 @@ a.editable-click.editable-disabled:hover { | |||
| .datepicker table tr td span.active.disabled, | |||
| .datepicker table tr td span.active.disabled:hover { | |||
| background-color: #006dcc; | |||
| background-image: -moz-linear-gradient(top, #0088cc, #0044cc); | |||
| background-image: -ms-linear-gradient(top, #0088cc, #0044cc); | |||
| background-image: -moz-linear-gradient(to bottom, #0088cc, #0044cc); | |||
There was a problem hiding this comment.
Avoid vendor prefixes.
Color literals like #0088cc should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #0044cc should only be used in variable declarations; they should be referred to via variable everywhere else.
| background-image: linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: -webkit-linear-gradient(to bottom, #0088cc, #0044cc); | ||
| background-image: -o-linear-gradient(to bottom, #0088cc, #0044cc); | ||
| background-image: linear-gradient(to bottom, #0088cc, #0044cc); |
There was a problem hiding this comment.
Color literals like #0088cc should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #0044cc should only be used in variable declarations; they should be referred to via variable everywhere else.
| background-image: -o-linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: -webkit-linear-gradient(to bottom, #0088cc, #0044cc); | ||
| background-image: -o-linear-gradient(to bottom, #0088cc, #0044cc); |
There was a problem hiding this comment.
Avoid vendor prefixes.
Color literals like #0088cc should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #0044cc should only be used in variable declarations; they should be referred to via variable everywhere else.
| background-image: -webkit-linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: -o-linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: -webkit-linear-gradient(to bottom, #0088cc, #0044cc); |
There was a problem hiding this comment.
Avoid vendor prefixes.
Color literals like #0088cc should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #0044cc should only be used in variable declarations; they should be referred to via variable everywhere else.
| background-image: -moz-linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: -ms-linear-gradient(top, #0088cc, #0044cc); | ||
| background-image: -moz-linear-gradient(to bottom, #0088cc, #0044cc); | ||
| background-image: -ms-linear-gradient(to bottom, #0088cc, #0044cc); |
There was a problem hiding this comment.
Avoid vendor prefixes.
Color literals like #0088cc should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #0044cc should only be used in variable declarations; they should be referred to via variable everywhere else.
| @@ -474,12 +474,12 @@ a.editable-click.editable-disabled:hover { | |||
| .datepicker table tr td.active.disabled, | |||
| .datepicker table tr td.active.disabled:hover { | |||
| background-color: #006dcc; | |||
| background-image: -moz-linear-gradient(top, #0088cc, #0044cc); | |||
| background-image: -ms-linear-gradient(top, #0088cc, #0044cc); | |||
| background-image: -moz-linear-gradient(to bottom, #0088cc, #0044cc); | |||
There was a problem hiding this comment.
Avoid vendor prefixes.
Color literals like #0088cc should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #0044cc should only be used in variable declarations; they should be referred to via variable everywhere else.
| background-image: linear-gradient(top, #b3b3b3, #808080); | ||
| background-image: -webkit-linear-gradient(to bottom, #b3b3b3, #808080); | ||
| background-image: -o-linear-gradient(to bottom, #b3b3b3, #808080); | ||
| background-image: linear-gradient(to bottom, #b3b3b3, #808080); |
There was a problem hiding this comment.
Color literals like #b3b3b3 should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #808080 should only be used in variable declarations; they should be referred to via variable everywhere else.
| background-image: -o-linear-gradient(top, #b3b3b3, #808080); | ||
| background-image: linear-gradient(top, #b3b3b3, #808080); | ||
| background-image: -webkit-linear-gradient(to bottom, #b3b3b3, #808080); | ||
| background-image: -o-linear-gradient(to bottom, #b3b3b3, #808080); |
There was a problem hiding this comment.
Avoid vendor prefixes.
Color literals like #b3b3b3 should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #808080 should only be used in variable declarations; they should be referred to via variable everywhere else.
| background-image: -webkit-linear-gradient(top, #b3b3b3, #808080); | ||
| background-image: -o-linear-gradient(top, #b3b3b3, #808080); | ||
| background-image: linear-gradient(top, #b3b3b3, #808080); | ||
| background-image: -webkit-linear-gradient(to bottom, #b3b3b3, #808080); |
There was a problem hiding this comment.
Avoid vendor prefixes.
Color literals like #b3b3b3 should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #808080 should only be used in variable declarations; they should be referred to via variable everywhere else.
| background-image: -moz-linear-gradient(top, #b3b3b3, #808080); | ||
| background-image: -ms-linear-gradient(top, #b3b3b3, #808080); | ||
| background-image: -moz-linear-gradient(to bottom, #b3b3b3, #808080); | ||
| background-image: -ms-linear-gradient(to bottom, #b3b3b3, #808080); |
There was a problem hiding this comment.
Avoid vendor prefixes.
Color literals like #b3b3b3 should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #808080 should only be used in variable declarations; they should be referred to via variable everywhere else.
| @@ -423,12 +423,12 @@ a.editable-click.editable-disabled:hover { | |||
| .datepicker table tr td.selected.disabled, | |||
| .datepicker table tr td.selected.disabled:hover { | |||
| background-color: #9e9e9e; | |||
| background-image: -moz-linear-gradient(top, #b3b3b3, #808080); | |||
| background-image: -ms-linear-gradient(top, #b3b3b3, #808080); | |||
| background-image: -moz-linear-gradient(to bottom, #b3b3b3, #808080); | |||
There was a problem hiding this comment.
Avoid vendor prefixes.
Color literals like #b3b3b3 should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #808080 should only be used in variable declarations; they should be referred to via variable everywhere else.
| background-image: linear-gradient(top, #f3c17a, #f3e97a); | ||
| background-image: -webkit-linear-gradient(to bottom, #f3c17a, #f3e97a); | ||
| background-image: -o-linear-gradient(to bottom, #f3c17a, #f3e97a); | ||
| background-image: linear-gradient(to bottom, #f3c17a, #f3e97a); |
There was a problem hiding this comment.
Color literals like #f3c17a should only be used in variable declarations; they should be referred to via variable everywhere else.
Color literals like #f3e97a should only be used in variable declarations; they should be referred to via variable everywhere else.
|
Can you provide more descriptions? |
|
Thanks for more info. Other then that it's working fine on Rails 5? |
|
For our project, everything else works great. |
|
Thanks! |
This PR fixes deprecation warning (rails 5 / autoprefixer-rails v6.5):
autoprefixer: ... Gradient has outdated direction syntax. New syntax is like
to leftinstead ofright.