Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove secret from Youdao Zhiyun api request url #24

Closed
tpirc3 opened this issue Mar 9, 2018 · 1 comment
Closed

Remove secret from Youdao Zhiyun api request url #24

tpirc3 opened this issue Mar 9, 2018 · 1 comment

Comments

@tpirc3
Copy link

tpirc3 commented Mar 9, 2018

Remove secret from Youdao Zhiyun api request url, to avoid secret leaks

Possible solution:
add unset($key['secret']); before $api.http_build_query($key) in YoudaoTranslate.php
wensonsmith added a commit that referenced this issue Feb 6, 2020
@wensonsmith
fix: 去除 URL 中的 secret （#24）
2ae7edd
@wensonsmith
Copy link
Owner

Fixed ，Thank you !

@wensonsmith wensonsmith reopened this Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wensonsmith @tpirc3