Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: es modules in client #3550

Merged
merged 17 commits into from
Jul 22, 2021
Merged

refactor: es modules in client #3550

merged 17 commits into from
Jul 22, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

existing tests

Motivation / Use-Case

use ECMA modules there it possible

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #3550 (800549f) into master (0c07404) will increase coverage by 0.49%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3550      +/-   ##
==========================================
+ Coverage   93.53%   94.02%   +0.49%     
==========================================
  Files          18       15       -3     
  Lines        1284     1256      -28     
  Branches      431      431              
==========================================
- Hits         1201     1181      -20     
+ Misses         77       69       -8     
  Partials        6        6              
Impacted Files Coverage Δ
client-src/clients/SockJSClient.js 100.00% <ø> (ø)
client-src/clients/WebSocketClient.js 100.00% <ø> (ø)
client-src/utils/createSocketURL.js 100.00% <ø> (ø)
client-src/utils/getCurrentScriptSource.js 100.00% <ø> (ø)
client-src/utils/parseURL.js 88.23% <ø> (-1.77%) ⬇️
client-src/utils/reloadApp.js 82.60% <ø> (-2.01%) ⬇️
client-src/utils/sendMessage.js 83.33% <ø> (-2.39%) ⬇️
lib/utils/DevServerPlugin.js 100.00% <ø> (+2.17%) ⬆️
client-src/index.js 85.56% <40.00%> (-1.23%) ⬇️
client-src/utils/log.js 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c07404...800549f. Read the comment docs.

@alexander-akait alexander-akait merged commit 9307755 into master Jul 22, 2021
@alexander-akait alexander-akait deleted the es-modulesin-client branch July 22, 2021 15:46
const baseForModules = {
devtool: false,
mode: "development",
// TODO enable this in future after fix bug with `eval` in webpack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be wise to link to the bug for future reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants