-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: es modules in client #3550
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3550 +/- ##
==========================================
+ Coverage 93.53% 94.02% +0.49%
==========================================
Files 18 15 -3
Lines 1284 1256 -28
Branches 431 431
==========================================
- Hits 1201 1181 -20
+ Misses 77 69 -8
Partials 6 6
Continue to review full report at Codecov.
|
const baseForModules = { | ||
devtool: false, | ||
mode: "development", | ||
// TODO enable this in future after fix bug with `eval` in webpack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be wise to link to the bug for future reference
For Bugs and Features; did you add new tests?
existing tests
Motivation / Use-Case
use ECMA modules there it possible
Breaking Changes
No
Additional Info
No