Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: imporove processing of CLI flags #3313

Merged
merged 6 commits into from
May 21, 2021
Merged

fix: imporove processing of CLI flags #3313

merged 6 commits into from
May 21, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 18, 2021 •
edited
Loading

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

Fix #3306

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented May 18, 2021 •
edited
Loading

Codecov Report

Merging #3313 (3318ac7) into master (fd5a3f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3313   +/-   ##
=======================================
  Coverage   95.69%   95.69%           
=======================================
  Files          34       34           
  Lines        1279     1279           
  Branches      368      368           
=======================================
  Hits         1224     1224           
  Misses         51       51           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd5a3f7...3318ac7. Read the comment docs.

alexander-akait
alexander-akait reviewed May 20, 2021
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to write common function which allow to use, not only https, also open, --open --open-target and other cli options

@snitin315 snitin315 changed the title fix: processing of https related flags fix: imporove processing of CLI flags May 21, 2021
@snitin315 snitin315 requested a review from alexander-akait May 21, 2021 11:30
alexander-akait
alexander-akait reviewed May 21, 2021
View reviewed changes
test/cli/cli.test.js
})
.catch(done);
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add --open --open-target test here too?

alexander-akait
alexander-akait approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when CI will be green

@snitin315 snitin315 merged commit 32bc877 into master May 21, 2021
@snitin315 snitin315 deleted the fix-https branch May 21, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@anshumanv anshumanv anshumanv approved these changes

@hiroppy hiroppy Awaiting requested review from hiroppy hiroppy is a code owner

@knagaitsev knagaitsev Awaiting requested review from knagaitsev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@snitin315 @alexander-akait @anshumanv