Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer to open the host option #3115

Merged
merged 4 commits into from
Mar 26, 2021
Merged

fix: prefer to open the host option #3115

merged 4 commits into from
Mar 26, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

fixes #2874

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #3115 (d080229) into master (ca0b534) will increase coverage by 0.38%.
The diff coverage is 86.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3115      +/-   ##
==========================================
+ Coverage   91.78%   92.16%   +0.38%     
==========================================
  Files          37       37              
  Lines        1290     1289       -1     
  Branches      347      345       -2     
==========================================
+ Hits         1184     1188       +4     
+ Misses        100       96       -4     
+ Partials        6        5       -1     
Impacted Files Coverage Δ
lib/Server.js 94.57% <86.04%> (+1.07%) ⬆️
lib/utils/setupExitSignals.js 90.90% <0.00%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0b534...d080229. Read the comment docs.

@alexander-akait
Copy link
Member Author

We need search way how to test --host site.loc, i.e. we need modify /etc/hosts cross platform, maybe github actions allow to do it and add tests for this case

@alexander-akait
Copy link
Member Author

Github actions has really bad IPv6 supports

@alexander-akait alexander-akait merged commit 7e525eb into master Mar 26, 2021
@alexander-akait alexander-akait deleted the issue-2874 branch March 26, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.0.0-beta.0 and host option
1 participant