Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): update source-list-map v0.1.7...2.0.0 (dependencies) #565

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jun 29, 2017

What kind of change does this PR introduce?

chore

Did you add tests for your changes?

not required

If relevant, did you update the README?

not required

Summary

Just update deps

Does this PR introduce a breaking change?

No

Other information

@codecov
Copy link

codecov bot commented Jun 29, 2017

Codecov Report

Merging #565 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          10       10           
  Lines         367      367           
  Branches       87       87           
=======================================
  Hits          362      362           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fee601...f4f5fdc. Read the comment docs.

@TrySound
Copy link
Contributor

Don't update icss-utils. It comes with new behavior (selectors replacing) which may introduce some bugs because of plugins incompatibility.

@alexander-akait
Copy link
Member Author

alexander-akait commented Jun 29, 2017

@TrySound thanks for clarify

@TrySound
Copy link
Contributor

TrySound commented Jun 29, 2017

@evilebottnawi They're not bugs. This behavior is not used in old plugins. And such replacements can happend in unexpected way.

@michael-ciniawsky
Copy link
Member

@TrySound Offtopic: Can we update all postcss-modules-* to the latest version (PostCSS 6 Support) as a semver minor for the loader (final minor update, I start with new-loader as soon as possible). It's a separate PR though, but to clarify... 😛

@michael-ciniawsky michael-ciniawsky changed the title chore(package): update deps chore(package): update source-list-map v0.1.7...2.0.0 (dependencies) Jun 29, 2017
@michael-ciniawsky michael-ciniawsky added this to the 0.28.5 milestone Jun 29, 2017
@michael-ciniawsky michael-ciniawsky merged commit 8dafee7 into master Jun 29, 2017
@michael-ciniawsky michael-ciniawsky deleted the update-deps branch June 29, 2017 19:54
@TrySound
Copy link
Contributor

@michael-ciniawsky Sure. I first did update with no extra changes.

joshwiens added a commit that referenced this pull request Aug 17, 2017
@michael-ciniawsky michael-ciniawsky modified the milestone: 0.28.6 Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants