Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show divider only when there are preferredCountries #151

Merged
merged 3 commits into from
Feb 4, 2019

Conversation

Dviejopomata
Copy link
Collaborator

When there are no preferred countries, the dropdown shows a divider:
image

I think we can only show the divider, because it looks weird otherwise.

With this pr, when there are no preferred countries, it looks like this:
image

@webcat12345
Copy link
Owner

I would like to add you as a contributor @Dviejopomata

Copy link
Owner

@webcat12345 webcat12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@webcat12345
Copy link
Owner

@Dviejopomata could you please accept this invitation? /~https://github.com/webcat12345/ngx-intl-tel-input/invitations

You can manage the resource fully.

@Dviejopomata
Copy link
Collaborator Author

@webcat12345 Just accepted it, sorry, didn't notice

@Dviejopomata Dviejopomata merged commit e525fc8 into webcat12345:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants