-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to differentiate phone numbers between countries, canada and usa seems to have same dial code. So a valid US number is being flagged to Canada flag? #154
Comments
Good point regarding the same dial code "+1" google-libphonenumber library has a I've tested this on my build. @webcat12345 is there a specific reason you used If no, I could replace it and deploy. |
@pasevin @webcat12345 Even if you pass the country value to |
Oh, I understand now. You mean if I begin typing +1 415 ... it will automatically select Canadian flag instead of US. Is that right? I was thinking this is about validation, but it's about the input behavior. I'm currently swamped with work, so encourage anyone who has time to look into this. I myself will look into this when I find the time. But no ETA. |
I looked into this quickly and I can see that the proper way would be to use BUT, it will identify and select the country only after the number has been entered fully. I tested it on my build, and it works with US / CA differentiation. So the only issue is that the flag will not change until the whole number is completed. Is this acceptable? Any other ideas? |
No the flag should ideally change as user keeps typing. That will be the right user experience. |
Then I guess, it will take longer to come up with a custom solution, which matches
|
Okay please let me know when we can have this fixed. It's a prime feature. |
Great you are awesome. |
No description provided.
The text was updated successfully, but these errors were encountered: