-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update template to use next 14 and app router #19
Update template to use next 14 and app router #19
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
Thanks so much for your PR. Can you make sure the original design stay same? because I see testimonials, footer etc are changed. Also the source code includes unwanted files like /utils.
The Theme Toggle is also bit different and it doesn't appear sometimes. do you know why?
Will take a look. Thanks. |
…nal design. Look identical two the original site. I did not have any issue with the theme button.
@surjithctly I made the changes that you asked for. Let me know if there is anything else. |
now the components have moved, the root folder is no more required right? Also remove It is throwing build error. Thanks so much for your work. I really appreciate it. |
…lder and it is something that is selected by default when running create-next-app
@surjithctly cool I removed the StrapiImage.tsx file since it is no longer being used. I typically like to keep the src folder and it is something that is set to "yes" by default when running I ran 'yarn build' to test, everything worked. Let me know if there is anything else. Thanks. |
Thanks, I meant the |
@surjithctly yes, thank you. I used that folder as reference when refactoring. Forgot to remove it. Just update it and removed the unused components folder. |
Thank you for your effort @PaulBratslavsky It's merged. |
@surjithctly glad I can help.🙂 |
Ready for review.