Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streams: improve test coverage #49447

Merged
merged 12 commits into from
Dec 3, 2024
Merged

Streams: improve test coverage #49447

merged 12 commits into from
Dec 3, 2024

Conversation

MattiasBuelens
Copy link
Contributor

@MattiasBuelens MattiasBuelens mentioned this pull request Nov 29, 2024
Merged
domenic
domenic approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No notes; amazing work all around! I especially appreciate expanding the templated tests.

@annevk
Copy link
Member

annevk commented Dec 2, 2024

@ptomato Firefox being flaky on ShadowRealm tests seems problematic.

@ptomato
Copy link
Contributor

ptomato commented Dec 2, 2024

Ms2ger had a look at the flakiness and it should be addressed by #49465.

@MattiasBuelens @domenic
Test whether the remainder of a respond() fulfills a pending read(view)
bab860a
@MattiasBuelens @domenic
Add more tests for next() and return() methods in ReadableStream.from()
74860b3
@MattiasBuelens @domenic
Test next() returning and fulfilling with a non-object separately
4e42ca5
@MattiasBuelens @domenic
Test calling close() when abort() aborts signal
ca59a90
@MattiasBuelens @domenic
Test recursive calls from abort() when stream is started
a0bad1b
@MattiasBuelens @domenic
Test calling readable.cancel() from within flush or cancel
a2e8bcf
@MattiasBuelens @domenic
Test calling writable.abort() or .close() from within cancel
8683cd4
@MattiasBuelens @domenic
Test calling ReadableStream.from() with iterator methods returning a …
cfa85dd 
…non-object
@MattiasBuelens @domenic
Test whether enqueue() throws after close() or error()
431e9d1
@MattiasBuelens @domenic
Run more templated tests on readable byte streams
35ab41f
@MattiasBuelens @domenic
Test whether a stream can be unlocked with an already-released BYOB r…
b9da54d 
…eader
@MattiasBuelens @domenic
Test whether WritableStream constructor throws when given a type
e98c091
@domenic domenic force-pushed the streams-improve-test-coverage branch from 69f54f2 to e98c091 Compare December 3, 2024 01:18
@domenic domenic merged commit 7ef95a1 into web-platform-tests:master Dec 3, 2024
15 of 17 checks passed
@MattiasBuelens MattiasBuelens deleted the streams-improve-test-coverage branch December 3, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@ricea ricea Awaiting requested review from ricea

@wanderview wanderview Awaiting requested review from wanderview

@youennf youennf Awaiting requested review from youennf

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

Assignees

@wanderview wanderview

Labels
streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MattiasBuelens @annevk @ptomato @domenic @wanderview @wpt-pr-bot