Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve HarmonyAcceptDependency #7671

Merged
merged 1 commit into from
Aug 28, 2024
Merged

refactor: improve HarmonyAcceptDependency #7671

merged 1 commit into from
Aug 28, 2024

Conversation

shulaoda
Copy link
Collaborator

Summary

Related to #7422

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@shulaoda shulaoda marked this pull request as draft August 23, 2024 11:18
@netlify Netlify
Copy link

netlify bot commented Aug 23, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 2d0d932
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66c948999dce5d000889953c

@shulaoda shulaoda mentioned this pull request Aug 23, 2024
Closed
@shulaoda shulaoda force-pushed the refactor/harmony-accept-dependency branch from c3cddaf to 4baafeb Compare August 23, 2024 11:29
@shulaoda shulaoda force-pushed the refactor/harmony-accept-dependency branch from 4baafeb to 2d0d932 Compare August 24, 2024 02:42
@shulaoda shulaoda marked this pull request as ready for review August 24, 2024 05:23
@h-a-n-a h-a-n-a self-assigned this Aug 26, 2024
h-a-n-a
h-a-n-a approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@h-a-n-a h-a-n-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@h-a-n-a h-a-n-a merged commit 01ea59f into web-infra-dev:main Aug 28, 2024
29 checks passed
@shulaoda shulaoda deleted the refactor/harmony-accept-dependency branch August 28, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shulaoda @h-a-n-a