Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ARM64 Linux to CI matrix #1608

Merged
merged 9 commits into from
Sep 18, 2020
Merged

Add ARM64 Linux to CI matrix #1608

merged 9 commits into from
Sep 18, 2020

Conversation

MarkMcCaskey
Copy link
Contributor

Review

  • Add a short description of the the change to the CHANGELOG.md file

@MarkMcCaskey
Copy link
Contributor Author

bors try

@MarkMcCaskey MarkMcCaskey marked this pull request as ready for review September 10, 2020 23:39
@MarkMcCaskey
Copy link
Contributor Author

bors try-

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 10, 2020
@bors
Try #1608:
7bd8993
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020 •
edited
Loading

Codecov Report

Merging #1608 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1608      +/-   ##
==========================================
- Coverage   31.72%   31.72%   -0.01%     
==========================================
  Files         185      185              
  Lines       27000    27000              
==========================================
- Hits         8567     8565       -2     
- Misses      18433    18435       +2
Impacted Files Coverage Δ
lib/compiler-cranelift/src/config.rs 60.00% <0.00%> (-2.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e744a...6d4206a. Read the comment docs.

@bors
Copy link
Contributor

bors bot commented Sep 11, 2020

try

Build succeeded:

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 11, 2020
@bors
Try #1608:
16d8eb9
@bors
Copy link
Contributor

bors bot commented Sep 11, 2020

try

Build succeeded:

@MarkMcCaskey
Copy link
Contributor Author

Interesting failure /~https://github.com/wasmerio/wasmer/runs/1103249251

looks like we need libclang to build libffi for the CAPI to work on ARM

@MarkMcCaskey
Copy link
Contributor Author

bors try

@bors
Copy link
Contributor

bors bot commented Sep 17, 2020

try

Merge conflict.

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 17, 2020
@bors
Try #1608:
66697e2
@MarkMcCaskey
Copy link
Contributor Author

bors try-

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 17, 2020
@bors
Try #1608:
28aa982
@MarkMcCaskey
Copy link
Contributor Author

bors try-

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 17, 2020
@bors
Try #1608:
aa3281d
@MarkMcCaskey
Copy link
Contributor Author

bors try-

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 17, 2020
@bors
Try #1608:
44e8f83
@bors
Copy link
Contributor

bors bot commented Sep 17, 2020

try

Build succeeded:

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 18, 2020
@bors
Try #1608:
b3a3fd8
@bors
Copy link
Contributor

bors bot commented Sep 18, 2020

try

Build succeeded:

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 18, 2020
@bors
Try #1608:
e4349c0
@MarkMcCaskey
Copy link
Contributor Author

bors try-

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 18, 2020
@bors
Try #1608:
80c29fa
@MarkMcCaskey MarkMcCaskey mentioned this pull request Sep 18, 2020
Merged
@bors
Copy link
Contributor

bors bot commented Sep 18, 2020

try

Build succeeded:

nlewycky
nlewycky reviewed Sep 18, 2020
View reviewed changes
.github/workflows/main.yaml
asset_name: wasmer-darwin-amd64.tar.gz
asset_content_type: application/gzip
- name: Upload Release Asset Linux aarch64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to be consistent about "arm" vs. "aarch64". I'm fine with either myself (I live my best life by pretending arm32 doesn't exist) but if you want to leave open the possibility of 32-bit arm in the future, change 'arm' to 'aarch64' throughout this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! All the remaining uses are required as that's the label that Github Actions uses (ARM64)

nlewycky
nlewycky reviewed Sep 18, 2020
View reviewed changes
bors.toml Outdated Show resolved Hide resolved
@MarkMcCaskey @nlewycky
Update bors.toml
6d4206a 
Co-authored-by: nlewycky <nick@wasmer.io>
@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Sep 18, 2020
@bors @MarkMcCaskey
Merge #1608
1620b86 
1608: Add ARM64 Linux to CI matrix r=MarkMcCaskey a=MarkMcCaskey



# Review

- [ ] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mark McCaskey <5770194+MarkMcCaskey@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Sep 18, 2020

Canceled.

@MarkMcCaskey
Copy link
Contributor Author

bors r-

@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 18, 2020

Build succeeded:

@bors bors bot merged commit b137679 into master Sep 18, 2020
@bors bors bot deleted the feature/add-arm64-to-ci-matrix branch September 18, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewycky nlewycky nlewycky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkMcCaskey @codecov-commenter @nlewycky