Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove flaky test debug logs from rln tests #3303

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

NagyZoltanPeter
Copy link
Contributor

Description

#3227 introduced a serie of debug logs to tackle flaky tests. This PR is about to remove those polluting logs out of scope now.

Changes

Removed only tracking debug logs.

How to test

Only test code changed.

@NagyZoltanPeter
Copy link
Contributor Author

@Ivansete-status : there are similar info logs for store and legacy store tests. Are those still necessary?

Copy link

github-actions bot commented Feb 20, 2025

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3303

Built from 9618aad

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯

@Ivansete-status
Copy link
Collaborator

@Ivansete-status : there are similar info logs for store and legacy store tests. Are those still necessary?

ah okay, I think no longer necessary

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@NagyZoltanPeter NagyZoltanPeter merged commit f08ba90 into master Feb 28, 2025
11 of 12 checks passed
@NagyZoltanPeter NagyZoltanPeter deleted the chore-remove-flaky-test-debug-logs branch February 28, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants