chore: remove warnings

[richard-ramos]

While attempting to compile libwaku from within status-desktop, even tho I'm using the same nim version, it failed to compile with some warnings like:

/home/richard/status/status-desktop/vendor/status-go/third_party/nwaku/waku/waku_archive_legacy/archive.nim(227, 23) Error: getMessagesV2 is deprecated [Deprecated]
stack trace: (most recent call last)
/home/richard/status/status-desktop/vendor/status-go/third_party/nwaku/vendor/nimbus-build-system/vendor/Nim/lib/system/nimscript.nim(421, 18)
/home/richard/status/status-desktop/vendor/status-go/third_party/nwaku/waku.nimble(169, 3) libwakuDynamicTask
/home/richard/status/status-desktop/vendor/status-go/third_party/nwaku/waku.nimble(69, 5) buildLibrary
/home/richard/status/status-desktop/vendor/status-go/third_party/nwaku/vendor/nimbus-build-system/vendor/Nim/lib/system/nimscript.nim(265, 7) exec
/home/richard/status/status-desktop/vendor/status-go/third_party/nwaku/vendor/nimbus-build-system/vendor/Nim/lib/system/nimscript.nim(265, 7) Error: unhandled exception: FAILED: nim c --out:build/libwaku.so --threads:on --app:lib --opt:size --noMain --mm:refc --header --undef:metrics -d:chronicles_line_numbers -d:chronicles_runtime_filtering=on -d:chronicles_sinks="textlines,json" -d:chronicles_default_output_device=Dynamic -d:chronicles_disabled_topics="eth,dnsdisc.client"  --verbosity:0 --hints:off -d:chronicles_log_level=TRACE -d:git_version="v0.33.0-26-gab7618" -d:release --passL:libnegentropy.a --passL:-lcrypto --passL:-lssl --passL:-lstdc++ --passL:librln_v0.5.1.a --passL:-lm library/libwaku.nim [OSError]

for both using deprecated functions, as well as unused imports.

Another error I saw was:

 Error: conversion to enum with holes is unsafe` is triggered

I could not figure out the reason why in status-desktop this happens, so I decided to fix the code instead which was faster:

• Removes deprecation and unused import warnings for libwaku. The other targets remain unmodified
• Removes unused imports.
• Adds .base. pragma to SubscriptionObserver.onSubscribe
• Uses casting for uint to enums conversions.. This casting should be safe as we are already limiting the values we accept on the case that precedes the cast
• Update nim-chronicles version so we have access to RfcUtcTime compile option

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3106

Built from b198012

[gabrielmer]

LGTM, thank you!

[Ivansete-status]

Amazing! Thanks for it! 💯