Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix go mod v2 #199

Merged
merged 1 commit into from
Oct 27, 2021
Merged

fix go mod v2 #199

merged 1 commit into from
Oct 27, 2021

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented Oct 26, 2021 •
edited
Loading

Description

Our go.mod was missing the v2 path in the name which caused issues with the go modules repo from syncing it

I built local builds and a container with the fixed v2 path without issues. We'll have to cut a new release for this

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ddymko ddymko requested a review from mamclaughlin October 26, 2021 22:53
@ddymko ddymko changed the base branch from v2 to master October 26, 2021 22:53
@ddymko ddymko added the bug Something isn't working label Oct 26, 2021
@ddymko ddymko merged commit a311ef5 into vultr:master Oct 27, 2021
@ddymko ddymko deleted the v2 branch October 27, 2021 12:46
@ddymko ddymko mentioned this pull request Oct 27, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamclaughlin mamclaughlin mamclaughlin approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddymko @mamclaughlin