Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddIPv4 returns change #77

Merged
merged 2 commits into from
Aug 25, 2020
Merged

AddIPv4 returns change #77

merged 2 commits into from
Aug 25, 2020

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented Aug 25, 2020

Description

AddIPv4 will now return the IP address that was just created.

Related Issues

Closes #76

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ddymko ddymko added this to the 0.5.0 milestone Aug 25, 2020
@ddymko ddymko requested a review from mamclaughlin August 25, 2020 16:32
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #77 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   71.98%   72.00%   +0.02%     
==========================================
  Files          24       24              
  Lines        2702     2704       +2     
==========================================
+ Hits         1945     1947       +2     
  Misses        381      381              
  Partials      376      376              
Impacted Files Coverage Δ
server.go 71.29% <66.66%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0aaa9b...a34ed58. Read the comment docs.

@ddymko ddymko merged commit 83ab8ff into vultr:master Aug 25, 2020
@ddymko ddymko deleted the create-ipv4-change branch September 22, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Server: AddIPV4 change returns
2 participants