Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lb updates #62

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Lb updates #62

merged 2 commits into from
Apr 29, 2020

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented Apr 29, 2020

Description

Adding the new functionality for the LB api to govultr

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ddymko ddymko requested a review from mamclaughlin April 29, 2020 17:59
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #62 into master will increase coverage by 0.08%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   72.00%   72.08%   +0.08%     
==========================================
  Files          24       24              
  Lines        2668     2683      +15     
==========================================
+ Hits         1921     1934      +13     
- Misses        376      377       +1     
- Partials      371      372       +1     
Impacted Files Coverage Δ
load_balancer.go 73.70% <87.50%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f712747...d3e2245. Read the comment docs.

@ddymko ddymko added the enhancement New feature or request label Apr 29, 2020
@ddymko ddymko merged commit add15ee into vultr:master Apr 29, 2020
@ddymko ddymko mentioned this pull request Apr 29, 2020
3 tasks
@ddymko ddymko deleted the lb-updates branch September 22, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants