Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing load balancer SSL fields and AutoSSL struct #352

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Add missing load balancer SSL fields and AutoSSL struct #352

merged 3 commits into from
Jan 17, 2025

Conversation

mondragonfx
Copy link
Contributor

Description

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

optik-aper
optik-aper reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/~https://github.com/vultr/govultr/blob/master/load_balancer.go#L67

Wrong struct type here

optik-aper
optik-aper reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/~https://github.com/vultr/govultr/blob/master/load_balancer.go#L37

Need AutoSSL in this struct

optik-aper
optik-aper requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need these structs updated first

@optik-aper optik-aper added the bug Something isn't working label Jan 16, 2025
@optik-aper optik-aper changed the title Update SSL Configs Add missing load balancer SSL fields and AutoSSL struct Jan 16, 2025
optik-aper
optik-aper approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@optik-aper optik-aper merged commit d958d19 into vultr:master Jan 17, 2025
6 checks passed
@optik-aper optik-aper mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optik-aper optik-aper optik-aper approved these changes

Assignees

@mondragonfx mondragonfx

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondragonfx @optik-aper