Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make QueryType a regular Vulkan enum #2438

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Dec 28, 2023

Changelog:

### Breaking changes
Changes to queries:
- `QueryType` is now a regular Vulkan enum like others in Vulkano.
- The `QueryType::result_len` method is moved to `QueryPool`, and now takes result flags into account.
- `QueryPoolCreateInfo` now has a `pipeline_statistics` field to specify the pipeline statistics flags.
- The `CommandBufferInheritanceInfo::query_statistic_flags` field is renamed to `pipeline_statistics` to match Vulkan.

This brings Vulkano a bit closer to Vulkan again.

@marc0246 marc0246 merged commit 9e82527 into vulkano-rs:master Jan 2, 2024
marc0246 added a commit that referenced this pull request Jan 2, 2024
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
* Make `QueryType` a regular Vulkan enum

* More consistency with Vulkan
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua Rua deleted the query-type branch February 3, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants