Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge PrimaryAutoCommandBuffer and SecondaryAutoCommandBuffer into CommandBuffer #2425

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Merge PrimaryAutoCommandBuffer and SecondaryAutoCommandBuffer into CommandBuffer #2425

merged 6 commits into from
Dec 20, 2023

Conversation

marc0246
Copy link
Contributor

Changelog:

### Breaking changes
Changes to command buffers:
- Merged `{Primary,Secondary}AutoCommandBuffer` into `CommandBuffer` and the corresponding `RecordingCommandBuffer::{primary,secondary}` into `new`.
- `RecordingCommandBuffer` no longer has a type parameter for the command buffer level.

### Bugs fixed
- `RawRecordingCommandBuffer::end` being safe to call.

@marc0246 marc0246 force-pushed the command-buffer-level branch from cf813ad to 8d7ad15 Compare December 13, 2023 12:47
@Rua Rua merged commit 00bb621 into vulkano-rs:master Dec 20, 2023
@marc0246 marc0246 deleted the command-buffer-level branch December 20, 2023 12:04
Rua added a commit that referenced this pull request Dec 20, 2023
@Rua
#2425 changelog
a4d889f
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
Merge PrimaryAutoCommandBuffer and SecondaryAutoCommandBuffer int…
fe806ef 
…o `CommandBuffer` (vulkano-rs#2425)

* Merge `PrimaryAutoCommandBuffer` and `SecondaryAutoCommandBuffer`

* Fix docs

* Fix examples

* Move command buffer creation validation to `RawRecordingCommandBuffer`

* Fix `RawRecordingCommandBuffer::end` being safe to call

* Remove unsafe block inside `RawRecordingCommandBuffer::end`
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
vulkano-rs#2425 changelog
71bc31b
marc0246 added a commit to marc0246/vulkano that referenced this pull request Oct 15, 2024
@marc0246
Revert vulkano-rs#2425
e39de0d
@marc0246 marc0246 mentioned this pull request Oct 15, 2024
Merged
marc0246 added a commit to marc0246/vulkano that referenced this pull request Oct 16, 2024
@marc0246
Revert vulkano-rs#2425
7d891c9
Rua pushed a commit that referenced this pull request Oct 18, 2024
@marc0246
Revert #2425 (#2576)
5749fef
Rua added a commit that referenced this pull request Oct 18, 2024
@Rua
#2425 changelog
dc61914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rua Rua Rua left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marc0246 @Rua