Optimize memory layout checks and fix allocation soundness #2122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two new types and a new type alias:
DeviceLayout
,DeviceAlignment
andNonZeroDeviceSize
. Previously, allocation sizes and alignments were verified in the functions that allocate, and in functions that construct buffers. All that is now gone as those checks have been moved toDeviceLayout
, which is a replica of std'sLayout
, but for Vulkan. Another issue was that previously, no checks were made whether the allocation size would overflow when rounded up, which would lead to undefined behavior.DeviceLayout
's size can not overflowi64::MAX
, which eliminates that concern.I've also marked some private functions
unsafe
and added more thourough safety documentation for them, and tried to document every possible case of arithmetic overflow as well. Hopefully this will make it easier to review the code and change it in the future.