Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect aspects in barriers for depth+stencil images #2108

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Fix incorrect aspects in barriers for depth+stencil images #2108

merged 2 commits into from
Dec 30, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Dec 19, 2022 •
edited
Loading

Changelog:

### Bugs fixed
- Fixed wrong aspects being used in pipeline barriers when an image view selects one aspect of a combined depth+stencil image.
- Fixed panic when building a finished command buffer, if the command buffer contains commands that use only some subresources of an image.

This was reported by @itmuckel on Discord. Thanks!

@Rua Rua marked this pull request as draft December 19, 2022 17:47
@Rua Rua marked this pull request as ready for review December 28, 2022 20:03
@AustinJ235 AustinJ235 merged commit aabe529 into vulkano-rs:master Dec 30, 2022
AustinJ235 added a commit that referenced this pull request Dec 30, 2022
@AustinJ235
#2108 Changelog
7fec2a6
@Rua Rua deleted the depth-stencil-barrier branch October 25, 2023 14:25
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
Fix incorrect aspects in barriers for depth+stencil images (vulkano-r…
bbb1c1f 
…s#2108)

* Fix incorrect aspects in barriers for depth+stencil images

* Account for first_use possibly being empty
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@AustinJ235 @hakolao
vulkano-rs#2108 Changelog
feb1345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinJ235 AustinJ235 AustinJ235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @AustinJ235