Allow waiting on SwapchainAcquireFuture #2080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Fixes: #1218
It was previously theoretically possible to wait on
SwapchainAcquireFuture
by dropping it.But if you dropped it, it became impossible to actually present the image, as
then_swapchain_present
requiresacquire_future
to have been joined.Why might you want to wait for the swapchain acquire?
Is this the best design?
There was some discussion on discord about making acquire_next_image return some opaque object that did more things automatically. Or perhaps tracking the acquire state on the image instead of with this future.
But this approach achieve much the same result, and doesn't require invasive refactoring.