Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move resource locking to submit function #2041

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Move resource locking to submit function #2041

merged 1 commit into from
Oct 23, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Oct 20, 2022

Changelog:

### Breaking changes
Changes to command buffers:
- The `PrimaryCommandBuffer` and `SecondaryCommandBuffer` traits are renamed to `PrimaryCommandBufferAbstract` and `SecondaryCommandBufferAbstract`.

The resource locking code that was previously implemented in the lock_submit function of the PrimaryCommandBuffer trait, is now moved to the Queue::submit function. It's also implemented now as a mutex-guarded CommandBufferState type, similar to how state was already implemented for buffers, images, fences and semaphores.

AustinJ235
AustinJ235 approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AustinJ235 AustinJ235 merged commit 0b5ad98 into vulkano-rs:master Oct 23, 2022
AustinJ235 added a commit that referenced this pull request Oct 23, 2022
@AustinJ235
#2041 Changelog
2738541
@Rua Rua deleted the lock-submit branch December 6, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinJ235 AustinJ235 AustinJ235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @AustinJ235