Buffer and image uploads take a command buffer instead of making one #2030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Remove this line (and remove the bullet from the previous one to merge it into the line above):
Add:
Creating a new command buffer builder, recording a single copy command onto it, and then building and submitting a single queue command with just the one tiny command buffer is not very efficient. If a lot of things are uploaded, this can also lead to stack overflows when you try to flush this giant pile of futures all at once, as discovered on Discord. With these changes, the user has the freedom to manage this a bit better themselves, and they can group all uploads into a single command buffer if they wish.