Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or allow all Clippy errors, re-enable dead code and unused variable warnings #1953

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Aug 12, 2022

Changelog:

- Improvements to compiler linting:
  - Most clippy warnings and errors have been fixed, and the remainder is explicitly allowed in each crate root. Some of these may be re-enabled in the future if desired.
  - Warnings for dead code and unused variables have been re-enabled and fixed.

A huge number of changed files here, but nothing has been changed semantically (hopefully). This makes clippy actually usable, and also re-enables the warnings for dead code and unused variables, which were disabled but with a note to re-enable them at some point. I explicitly disabled the clippy warnings that I felt were too pedantic or opinionated.

Fixes #1195.

Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Didn't notice any semantic changes. Great work!

@AustinJ235 AustinJ235 merged commit f0e6e4c into vulkano-rs:master Aug 12, 2022
AustinJ235 added a commit that referenced this pull request Aug 12, 2022
@Rua Rua deleted the clippy branch September 17, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clippy warns about "ref_in_deref" when using impl_vertex macro
2 participants