Fix or allow all Clippy errors, re-enable dead code and unused variable warnings #1953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
A huge number of changed files here, but nothing has been changed semantically (hopefully). This makes clippy actually usable, and also re-enables the warnings for dead code and unused variables, which were disabled but with a note to re-enable them at some point. I explicitly disabled the clippy warnings that I felt were too pedantic or opinionated.
Fixes #1195.