Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow dispatch calls with dimensions of zero-length #1886

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Disallow dispatch calls with dimensions of zero-length #1886

merged 2 commits into from
Apr 29, 2022

Conversation

ryco117
Copy link
Contributor

@ryco117 ryco117 commented Apr 29, 2022

  1. This is meant to address Using dispatch with dimension 0 along any axis triggers a kernel crash, or freezes the OS #1219 by adding an additional check to check_dispatch() for a zero-length dimension

  2. Please put changelog entries in the description of this Pull Request
    if knowledge of this change could be valuable to users. No need to put the
    entries to the changelog directly, they will be transferred to the changelog
    files(CHANGELOG_VULKANO.md and CHANGELOG_VK_SYS.md)
    by maintainers right after the Pull Request merge.

    • Entries for Vulkano changelog:
      • Added new enum value CheckDispatchError::ZeroLengthDimensions to be returned when dispatch() is called with dimension(s) of length zero.
  3. Run cargo fmt on the changes.

  4. Make sure that the changes are covered by unit-tests.

  5. Update documentation to reflect any user-facing changes - in this repository.

Let me know if there are any concerns! (and yes, this issue is pretty low-hanging fruit :P )

@Rua
Copy link
Contributor

Rua commented Apr 29, 2022

Seems like a simple enough fix, thanks!

@Rua Rua merged commit f1cce25 into vulkano-rs:master Apr 29, 2022
Rua added a commit that referenced this pull request Apr 29, 2022
@ryco117 ryco117 deleted the nonzero-dispatch branch April 30, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants