Disallow dispatch calls with dimensions of zero-length #1886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to address Using dispatch with dimension 0 along any axis triggers a kernel crash, or freezes the OS #1219 by adding an additional check to
check_dispatch()
for a zero-length dimensionPlease put changelog entries in the description of this Pull Request
if knowledge of this change could be valuable to users. No need to put the
entries to the changelog directly, they will be transferred to the changelog
files(
CHANGELOG_VULKANO.md
andCHANGELOG_VK_SYS.md
)by maintainers right after the Pull Request merge.
CheckDispatchError::ZeroLengthDimensions
to be returned whendispatch()
is called with dimension(s) of length zero.Run
cargo fmt
on the changes.Make sure that the changes are covered by unit-tests.
Update documentation to reflect any user-facing changes - in this repository.
Let me know if there are any concerns! (and yes, this issue is pretty low-hanging fruit :P )