fix: allow finding async component stubs by definition #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
xanf
commented
Apr 30, 2023
| @@ -230,7 +243,8 @@ export function createStubComponentsTransformer({ | |||
| return ( | |||
| config.plugins.createStubs?.({ | |||
| name: stubName, | |||
| component: type | |||
| component: type, | |||
| registerStub | |||
There was a problem hiding this comment.
We want to provide an ability to mess with stubs (including async componentS) to the plugin system, so our plugins will be as capable as original createStub
|
A bit of off-topic: happy to be back to active development here! We have a Vue.js 3 migration working group established in GitLab, so I will be happy to dedicate more time polishing things here and adding new cool features |
xanf
force-pushed
the
xanf-fix-shallow-mount-async-stubs
branch
4 times, most recently
from
ba8bbb3 to
0546844
Compare
xanf
force-pushed
the
xanf-fix-shallow-mount-async-stubs
branch
from
0546844 to
15fb751
Compare
xanf
commented
Apr 30, 2023
| const AsyncComponentWithoutName = defineAsyncComponent(async () => ({ | ||
| template: '<span>AsyncComponent</span>' | ||
| })) | ||
|
|
||
| it('stubs async component with name', async () => { | ||
| const AsyncComponent = defineAsyncComponent(async () => ({ |
There was a problem hiding this comment.
We need to move component definition inside test, because otherwise for second test __asyncResolved will be already defined from previous test
lmiller1990
reviewed
May 1, 2023
lmiller1990
approved these changes
May 1, 2023
cexbrayat
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR introduces an ability to find async component stubs by definition of underlying component, not just by wrapper itself
It also mimics
@vue/test-utils@1.xbehavior (well, kinda) -@vue/test-utils@1.xwas unable to stub async components due to limitations in our patch approach, so "finding" always worked cause there were no stubs