modified templates to dereference class parameters #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcoding references to $snmpd::params::foo in the templates means that the parameters passed into the class get dropped on the floor. :)
|
Good catch! I should probably get around to actually testing this module. |
razorsedge
added a commit
that referenced
this pull request
Jul 4, 2012
Modified templates to dereference class parameters
skylar2-uw
added a commit
to uwgsit/puppet-snmp
that referenced
this pull request
Feb 25, 2023
# This is the 1st commit message: set runtime options for Ubuntu 22.04 based on 20.04 # This is the commit message voxpupuli#2: no longer need snmpd_options # This is the commit message voxpupuli#3: add Ubuntu 22.04 to CI test suite coverage
skylar2-uw
added a commit
to uwgsit/puppet-snmp
that referenced
this pull request
Feb 27, 2023
# This is the 1st commit message: set runtime options for Ubuntu 22.04 based on 20.04 # This is the commit message voxpupuli#2: no longer need snmpd_options # This is the commit message voxpupuli#3: add Ubuntu 22.04 to CI test suite coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcoding references to
$snmpd::params::fooin the templates means thatthe parameters passed into the class get dropped on the floor. :)
This patch replaces these references with the corresponding
$snmpd::<submodule>::fooreference.