Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error rendering #29

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Error rendering #29

merged 7 commits into from
Aug 27, 2024

Conversation

volfpeter
Copy link
Owner

The PR contains breaking changes, so the new release that'll officially get these features will be 2.0.

Features:

Breaking changes:

  • To support error rendering, the RequestComponentSelector protocol got a second argument (error: Exception | None).
  • The internals of Jinja changed slightly.

How to upgrade:

  • If you have custom RequestComponentSelector implementations, then please add the new argument to the get_component_id() method. Well-behaved RequestComponentSelectors that don's support error rendering should reraise the received error if it's not None (although not doing so will not break anything as result and errors are clearly separated in Jinja and the core decorators don't rely on this protocol).
  • If you've overridden any of the protected methods of Jinja, please go through this PR so you can upgrade your custom implementation.

@volfpeter volfpeter added the enhancement New feature or request label Aug 27, 2024
@volfpeter volfpeter self-assigned this Aug 27, 2024
@volfpeter volfpeter merged commit 33f374e into main Aug 27, 2024
2 checks passed
@volfpeter volfpeter deleted the error-rendering branch August 27, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant