Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vc-scheduler: fix omitting check ancestor-queues' real-capability in capacity plugin. #3940

Merged
merged 3 commits into from
Jan 7, 2025
Merged

vc-scheduler: fix omitting check ancestor-queues' real-capability in capacity plugin. #3940

merged 3 commits into from
Jan 7, 2025
+51 −16

Conversation

bogo-y
Copy link
Contributor

@bogo-y bogo-y commented Dec 30, 2024

fix #3932

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 30, 2024
@bogo-y
Copy link
Contributor Author

bogo-y commented Dec 30, 2024

  1. fix the AllocatableFn in capacity plugin
  2. add UT for new logic
  3. disable Allocatable check in reclaim action
  4. add PreemptiveFn in proportion plugin
    /PTAL @Monokaix @JesseStutler

@JesseStutler
Copy link
Member

JesseStutler commented Dec 30, 2024 •
edited
Loading

Great Job! Clean code and clean commits!
/lgtm
/area scheduling

@volcano-sh-bot
Copy link
Contributor

@JesseStutler: The label(s) area/scheduler cannot be applied. These labels are supported: ``

In response to this:

Great Job! Clean code and clean commits!
/lgtm
/area scheduler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. area/scheduling labels Dec 30, 2024
@bogo-y bogo-y requested a review from lowang-bh December 31, 2024 06:41
@Monokaix
Copy link
Member

/ok-to-test

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 31, 2024
hwdef
hwdef reviewed Jan 2, 2025
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
@bogo-y bogo-y force-pushed the capacity branch 2 times, most recently from 327c182 to c069994 Compare January 3, 2025 02:53
bogo-y and others added 2 commits January 6, 2025 19:49
@bogo-y @Monokaix
skip check ssn.Allocatable in reclaim action and add preemptiveFn in …
61f9c9d 
…proportion plugin

Signed-off-by: bogo_y <bogo.ysh@gmail.com>
Co-authored-by: Monokaix <changxuzheng@huawei.com>
@bogo-y
add unit test for capacity plugin
a9ecbd5 
Signed-off-by: bogo_y <bogo.ysh@gmail.com>
@Monokaix
Copy link
Member

Monokaix commented Jan 7, 2025

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@lowang-bh
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@volcano-sh-bot volcano-sh-bot merged commit ef95756 into volcano-sh:master Jan 7, 2025
17 checks passed
@bogo-y bogo-y deleted the capacity branch January 7, 2025 06:30
@bogo-y bogo-y mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@Monokaix Monokaix Monokaix left review comments

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

@lowang-bh lowang-bh Awaiting requested review from lowang-bh

Assignees

@hwdef hwdef

@lowang-bh lowang-bh

@JesseStutler JesseStutler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/scheduling lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

capacity plugin only check leaf queue's real-capability.
6 participants
@bogo-y @JesseStutler @volcano-sh-bot @Monokaix @lowang-bh @hwdef