Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitForNetIp to take arguments allowing to wait for specific nic(s) #653

Closed
rickardrosen opened this issue Jan 5, 2017 · 1 comment
Closed

Comments

@rickardrosen
Copy link

We are experiencing the following issue when using terraform to provision vsphere virtual machines.

If we add multiple NIC to a host, and the additional nics do not receive an IP address, terraform will not complete provisioning as it calls the waitForNetIp function.

In our scenario we're provisioning hosts that will use additional nics as bridge interfaces, and as such will have a mac address, but no IP.

To temporarily solve this I made this update to the waitForNetIp:

		for _, ips := range macs {
			if len(ips) > 0 {
				return true
			}
		}

		return false

It would be great if the WaitForNetIp could receive an array of nic# to specifically wait for.

This way we could mark one (or more) NIC as "management" in terraform and waitForNetIp could disregard the others.

Does it make sense?

dougm added a commit to dougm/govmomi that referenced this issue Jan 24, 2017
With this option, WaitForNetIP can specify NIC(s) by MAC address or device name.

Fixes vmware#653
@dougm
Copy link
Member

dougm commented Jan 24, 2017

@rickardrosen (and hashicorp/terraform#7479 watchers) can you review #660 and let me know if that does what you need?

dougm added a commit that referenced this issue Jan 27, 2017
With this option, WaitForNetIP can specify NIC(s) by MAC address or device name.

Fixes #653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants