-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jsonnet support #8
Conversation
1d86a6b
to
0dbb49f
Compare
There's nothing wrong with this PR, but I'm confused where the Is the final version going to support external, or internal embedded files? as YAML, or jsonnet? |
That's true. However, this is not the final state of the kubeapps/installer. I am adding support for
The final version is for end users and we are already clear about the UX. Right now I am just trying to go over the scope for testing both yaml and jsonnet files. We haven't decided to go with YAML or jsonnet or both yet. I am fine with those options. I won't merge this PR until we agree on supporting jsonnet, otherwise I will just close it. |
@ngtuna we should embed the manifests right now. it should be a very simple tool with two (maximum three commands): The Then we need some minimal testing |
Should be closed now. We can open this discussion and implement in future if we think it's worth to use jsonnet file. |
Update the favicon and the placeholder
changing services for hub from NodePort to ClusterIP,
add repo deletion
This supports deploy kubeapps components via the
kubeapps.jsonnet
file.