Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet support #8

Closed
wants to merge 2 commits into from
Closed

Conversation

ngtuna
Copy link
Contributor

@ngtuna ngtuna commented Oct 31, 2017

This supports deploy kubeapps components via the kubeapps.jsonnet file.

$ d=$PWD/kubeapps-manifest
$ git clone --recurse-submodules /~https://github.com/kubeapps/manifest $d
$ export KUBECFG_JPATH=$d/lib:$d/vendor/kubecfg/lib:$d/vendor/ksonnet-lib
$ kubeapps up --file $d/kubeapps.jsonnet
$ kubeapps down --file $d/kubeapps.jsonnet

@ngtuna ngtuna requested a review from anguslees October 31, 2017 17:47
@anguslees
Copy link
Contributor

anguslees commented Nov 1, 2017

There's nothing wrong with this PR, but I'm confused where the kubeapps/installer codebase is going. We seem to have too many features for experimentation (imo) compared to the final goal as a single-file, just-works installer.

Is the final version going to support external, or internal embedded files? as YAML, or jsonnet?
Is it intended as a platform for us as devs to easily experiment with new files, or for end users? (does it offer anything beyond what a simple shell script would do for experimentation?)

@ngtuna
Copy link
Contributor Author

ngtuna commented Nov 1, 2017

There's nothing wrong with this PR, but I'm confused where the kubeapps/installer codebase is going. We seem to have too many features for experimentation (imo) compared to the final goal as a single-file, just-works installer.

That's true. However, this is not the final state of the kubeapps/installer. I am adding support for kubeapps.jsonnet file only for development purpose that means we can update the file and easily try kubeapps up. We won't embed the content of it into the installer code at this stage IMO until we release it.

Is the final version going to support external, or internal embedded files? as YAML, or jsonnet?
Is it intended as a platform for us as devs to easily experiment with new files, or for end users? (does it offer anything beyond what a simple shell script would do for experimentation?)

The final version is for end users and we are already clear about the UX. Right now I am just trying to go over the scope for testing both yaml and jsonnet files. We haven't decided to go with YAML or jsonnet or both yet. I am fine with those options. I won't merge this PR until we agree on supporting jsonnet, otherwise I will just close it.

@sebgoa
Copy link
Contributor

sebgoa commented Nov 2, 2017

@ngtuna we should embed the manifests right now.

it should be a very simple tool with two (maximum three commands): up and dashboard

The up just applys the manifests that are embedded. I don't know if we can embed jsonnet manifests from kubeapps/manifests or if those need to be expanded prior to being embedded.

Then we need some minimal testing

@ngtuna ngtuna mentioned this pull request Nov 3, 2017
@ngtuna
Copy link
Contributor Author

ngtuna commented Dec 20, 2017

Should be closed now. We can open this discussion and implement in future if we think it's worth to use jsonnet file.

@ngtuna ngtuna closed this Dec 20, 2017
arapulido pushed a commit to arapulido/kubeapps that referenced this pull request Feb 13, 2018
Update the favicon and the placeholder
prydonius added a commit that referenced this pull request Feb 23, 2018
changing services for hub from NodePort to ClusterIP,
prydonius added a commit to prydonius/kubeapps that referenced this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants