-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger GHA release workflow on tags following test-*
pattern
#5619
Conversation
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it seems like a temporary thing we need to be able to test the CI step. +1 as I don't wanna block it when on PTO, but find below some comments and concerns:
- Can't we just trigger the workflow (manually) from the github UI instead?
- Creating a release when we should not seems to be a bit risky if we forget to add the DEV variable. What about using the
github.ref
variable to set the DEV variable if the tag containstest-
or whatever? - The name
test-
perhaps is not the most accurate, anyway, it is a temporary thing, so doesn't really matter. - I'd add a comment
# TODO(xxx): yyy
saying it is a temporary thing that must be removed soon.
That would be tricky and would imply a lot of changes...
Let me think about it 🙂
Yeah, it looks like a good idea |
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
962484a
to
d11edd4
Compare
I've added the hack for this. Thanks @antgamdia! |
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
Signed-off-by: Jesús Benito Calzada bjesus@vmware.com
Description of the change
We need a way of being able to test the new release workflow in GHA. So far, it's only triggered on new tags following the pattern
v[0-9]+.[0-9]+.[0-9]+
, so we cannot trigger it unless a new release tag is created. To allow testing without generating new release tags, we have added a new condition that triggers the workflow when new tags following the patterntests-*
are created.Benefits
The release workflow can be triggered and tested without the need of creating new release tags.
Possible drawbacks
If we don't control the kind of tag that triggered the workflow, and deactivate the
DEV_MODE
for thekubeapps-main
workflow, we could generate an actual release on the Bitnami side upon the creation of newtest-*
tags.Applicable issues
Additional information
N/A