Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display output of kubeapps up #52

Merged
merged 5 commits into from
Nov 28, 2017
Merged

display output of kubeapps up #52

merged 5 commits into from
Nov 28, 2017

Conversation

ngtuna
Copy link
Contributor

@ngtuna ngtuna commented Nov 23, 2017 •
edited
Loading

  • add created-by=kubeapps to the YAML manifest
  • print out deploy, svc, statefulset
  • need to add label to pod
  • add tests

@ngtuna ngtuna mentioned this pull request Nov 23, 2017
Merged
@ngtuna ngtuna changed the title [WIP] display output of kubeapps up display output of kubeapps up Nov 28, 2017
andresmgot
andresmgot approved these changes Nov 28, 2017
View reviewed changes
Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ngtuna
Copy link
Contributor Author

ngtuna commented Nov 28, 2017

Thanks. I am landing it now.

@ngtuna ngtuna merged commit 77505a6 into vmware-tanzu:master Nov 28, 2017
arapulido pushed a commit to arapulido/kubeapps that referenced this pull request Feb 13, 2018
@prydonius
split tslint rules for dev and ci (vmware-tanzu#52)
95c6c61 
In development, console.log's are useful for debugging. This updates the
main tslint.json file to not error when console.log's are present, but
to just emit warnings. Since tslint doesn't have a stricter mode where
it fails on warnings also, I've created another tslint.ci.json file that
will emit errors if console.log's are present. This file will be used in
the CI and pre-commit hooks so when a developer is ready to commit a
change they will need to remove their debug statements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmgot andresmgot andresmgot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngtuna @andresmgot